gianm commented on code in PR #18121:
URL: https://github.com/apache/druid/pull/18121#discussion_r2162361983
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -553,11 +555,17 @@ private MSQTaskReportPayload runInternal(final
QueryListener queryListener, fina
countersSnapshot,
null
);
+ emitQueryMetrics(stopwatch);
// Emit summary metrics
emitSummaryMetrics(msqTaskReportPayload, querySpec);
return msqTaskReportPayload;
}
+ private void emitQueryMetrics(Stopwatch stopwatch)
+ {
+ context.emitMetric("query/time", stopwatch.millisElapsed());
Review Comment:
Yes, the `dataSource` metric as I've defined it here should only be attached
to the `query/time` and `query/cpu/time` metrics. All other metrics emitted by
the task should use `task.getDataSource()`. In the documentation we should call
this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
