kfaraz commented on code in PR #18192:
URL: https://github.com/apache/druid/pull/18192#discussion_r2181757263
##########
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClient.java:
##########
@@ -105,11 +105,11 @@ public interface CoordinatorClient
ListenableFuture<Void>
updateCoordinatorDynamicConfig(CoordinatorDynamicConfig dynamicConfig);
/**
- * Gets the lookup configuration for a tier.
+ * Gets the lookup configuration for a tier synchronously.
* <p>
* API: {@code GET /druid/coordinator/v1/lookups/config/<tier>}
*
* @param tier The name of the tier for which the lookup configuration is to
be fetched.
*/
- ListenableFuture<Map<String, LookupExtractorFactoryContainer>>
fetchLookupsForTier(String tier);
+ Map<String, LookupExtractorFactoryContainer>
synchronousFetchLookupsForTier(String tier);
Review Comment:
Nit: This is probably a little verbose
The style we generally follow is `sync` or `async`.
(See `SeekableStreamIndexTaskClient` for an example of methods like
`getStatusAsync`.)
Maybe just use `fetchLookupsForTierSync`.
Using `sync` as a prefix (`syncFetchLookupsForTier`) also makes the name a
little ambiguous as it makes
it sound like some syncing operation is involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
