gianm commented on code in PR #18196:
URL: https://github.com/apache/druid/pull/18196#discussion_r2182242576


##########
services/src/test/java/org/apache/druid/testing/embedded/EmbeddedBroker.java:
##########
@@ -54,6 +79,9 @@ private Broker(LifecycleInitHandler handler)
     @Override
     public Lifecycle initLifecycle(Injector injector)
     {
+      final BrokerServerView serverView = 
injector.getInstance(BrokerServerView.class);

Review Comment:
   I think you're right, it's better to add a Broker metric to keep this file 
simpler. The metric could be a monitor that emits the number of segments 
available per datasource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to