uds5501 commented on code in PR #18195:
URL: https://github.com/apache/druid/pull/18195#discussion_r2185440580


##########
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClientImpl.java:
##########
@@ -276,6 +290,99 @@ public Map<String, LookupExtractorFactoryContainer> 
fetchLookupsForTierSync(Stri
     }
   }
 
+  @Override
+  public JsonParserIterator<SegmentStatusInCluster> getMetadataSegmentsSync(
+      @Nullable Set<String> watchedDataSources
+  )
+  {
+    final StringBuilder pathBuilder = new StringBuilder(
+        
"/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus&includeRealtimeSegments");
+    if (watchedDataSources != null && !watchedDataSources.isEmpty()) {
+      for (String dataSource : watchedDataSources) {
+        
pathBuilder.append("&dataSource=").append(StringUtils.urlEncode(dataSource));

Review Comment:
   I have added the embedded tests for the endpoints touched in this PR and a 
few more.
   I am kind of stuck handling `fetchDataSourceInformation` as I am not able to 
run the coordinator with appropriate setting required (it's throwing a 404 
error and for some reason the `CoordinatorSegmentMetadataCache` is not being 
initialized (added the cluster in PR), will need help with that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to