gianm commented on code in PR #18200:
URL: https://github.com/apache/druid/pull/18200#discussion_r2188626807
##########
server/src/main/java/org/apache/druid/client/BatchServerInventoryView.java:
##########
@@ -243,13 +244,13 @@ protected void runSegmentCallbacks(
}
}
- private void runServerRemovedCallbacks(final DruidServer server)
+ private void runServerCallbacks(final Function<ServerCallback,
CallbackAction> fn)
{
- for (final Map.Entry<ServerRemovedCallback, Executor> entry :
serverRemovedCallbacks.entrySet()) {
+ for (final Map.Entry<ServerCallback, Executor> entry :
serverCallbacks.entrySet()) {
Review Comment:
Personally, I prefer the regular `for` in situations where the `forEach`
can't be a one-liner (& even sometimes then) so I kept it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
