GWphua opened a new pull request, #18212:
URL: https://github.com/apache/druid/pull/18212

   ### Description
   
   `
   [pool-13-thread-4] org.apache.druid.emitter.kafka.KafkaEmitter - Message 
lost counter: metricLost=[0], alertLost=[0], requestLost=[0], invalidLost=[0]
   `
   The above log is scheduled. We found the log to be very repetitive, and 
would like to change the functionality to only log when there's a problem (e.g. 
there are messages lost for the past scheduled minutes).
   
   
   #### Release note
   * Reduced Kafka Emitter logging to only report when messages are lost.
   
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `KafkaEmitter.java`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] a release note entry in the PR description.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to