github-advanced-security[bot] commented on code in PR #18207:
URL: https://github.com/apache/druid/pull/18207#discussion_r2191742916
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/compact/EmbeddedAutoCompactionTest.java:
##########
@@ -1742,84 +1666,85 @@
);
// Compact the MONTH segment
forceTriggerAutoCompaction(2);
- verifyQuery(INDEX_ROLLUP_QUERIES_RESOURCE, queryAndResultFields);
+ verifyScanResult("added", "57.0||459.0");
+ verifyScanResult("COUNT(*)", "2");
// Compact the WEEK segment
forceTriggerAutoCompaction(2);
- verifyQuery(INDEX_ROLLUP_QUERIES_RESOURCE, queryAndResultFields);
+ verifyScanResult("added", "57.0||459.0");
+ verifyScanResult("COUNT(*)", "2");
// Verify all task succeed
- List<TaskResponseObject> compactTasksBefore =
indexer.getCompleteTasksForDataSource(fullDatasourceName);
- for (TaskResponseObject taskResponseObject : compactTasksBefore) {
- Assert.assertEquals(TaskState.SUCCESS, taskResponseObject.getStatus());
+ List<TaskStatusPlus> compactTasksBefore =
getCompleteTasksForDataSource(fullDatasourceName);
+ for (TaskStatusPlus taskResponseObject : compactTasksBefore) {
+ Assertions.assertEquals(TaskState.SUCCESS,
taskResponseObject.getStatus());
Review Comment:
## Deprecated method or constructor invocation
Invoking [TaskStatusPlus.getStatus](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9392)
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/EmbeddedKafkaClusterMetricsTest.java:
##########
@@ -307,6 +307,85 @@
);
}
+ @Test
+ @Timeout(120)
+ public void test_ingestClusterMetrics_compactionSkipsLockedIntervals()
+ {
+ final int maxRowsPerSegment = 500;
+ final int compactedMaxRowsPerSegment = 5000;
+
+ final int taskCount = 2;
+ final int taskDurationMillis = 500;
+ final int taskCompletionTimeoutMillis = 5_000;
+
+ // Submit and start a supervisor
+ final String supervisorId = dataSource + "_supe";
+ final KafkaSupervisorSpec kafkaSupervisorSpec = createKafkaSupervisor(
+ supervisorId,
+ taskCount,
+ taskDurationMillis,
+ taskCompletionTimeoutMillis,
+ maxRowsPerSegment
+ );
+ cluster.callApi().onLeaderOverlord(
+ o -> o.postSupervisor(kafkaSupervisorSpec)
+ );
+
+ // Wait for some segments to be published
+ overlord.latchableEmitter().waitForEvent(
+ event -> event.hasMetricName("segment/txn/success")
+ .hasDimension(DruidMetrics.DATASOURCE, dataSource)
+ );
+
+ // Enable compaction supervisors on the Overlord
+ final ClusterCompactionConfig originalCompactionConfig =
cluster.callApi().onLeaderOverlord(
+ OverlordClient::getClusterCompactionConfig
+ );
+
+ final ClusterCompactionConfig updatedCompactionConfig
+ = new ClusterCompactionConfig(1.0, 10, null, true, null);
+ final UpdateResponse updateResponse = cluster.callApi().onLeaderOverlord(
+ o -> o.updateClusterCompactionConfig(updatedCompactionConfig)
+ );
+ Assertions.assertTrue(updateResponse.isSuccess());
+
+ // Submit a compaction supervisor for this datasource
+ final CompactionSupervisorSpec compactionSupervisorSpec = new
CompactionSupervisorSpec(
+ InlineSchemaDataSourceCompactionConfig
+ .builder()
+ .forDataSource(dataSource)
+ .withSkipOffsetFromLatest(Period.seconds(0))
+ .withMaxRowsPerSegment(compactedMaxRowsPerSegment)
Review Comment:
## Deprecated method or constructor invocation
Invoking [Builder.withMaxRowsPerSegment](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/9391)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
