clintropolis opened a new pull request, #18219:
URL: https://github.com/apache/druid/pull/18219

   ### Description
   This PR removes the `skipMaxRowsInMemoryCheck` parameter from 
`IncrementalIndex.add` since it seems to make things overly complicated to 
reason about. All callers that add rows check `canAppendRow()` (except the 
sampler, but it should have a small row limit anyway :shrug:), so this should 
be safe as far as I can tell.
   
   Because it is no longer needed after the changes to the `add` method, this 
PR also removes `IndexSizeExceededException`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to