imply-cheddar commented on PR #18216: URL: https://github.com/apache/druid/pull/18216#issuecomment-3051438524
This code change will append the new segment to the old set of segments. If that old set of segments had a non-zero core partition numbers, then the appended segment will carry the same set of core partitions (non-zero) and will publish the new appended segment with the extra appended partition num. This new segment will never actually be used in queries because the core partitions will never be fully loaded by the system as it is not a complete partition of data (the semantics of the system are that the core partitions must all exist for the segments in that time range to be considered complete, extra partitions *can* exist, but do not have to). This means that even in the case where this showed up (a segment was dropped and then new data came in), the newly created segment won't actually be queried. The correct fix for this is to generate a net-new version that is "better" than the previous version, adding more partitions to the unused segments is weird. IIRC, we used the static 1970 version just as a short-circuit because we weren't sure what the best version to use was in the case where nothing exists yet. At this point, we now understand why it's important to use a better version and the version of the lock should be "better" than the unused segments. Please revert this change and adjust to use a better version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org