uds5501 commented on code in PR #18195:
URL: https://github.com/apache/druid/pull/18195#discussion_r2195775594
##########
server/src/test/java/org/apache/druid/client/coordinator/CoordinatorClientImplTest.java:
##########
@@ -531,4 +553,300 @@ public void
test_fetchLookupsForTierSync_detailedEnabled() throws Exception
coordinatorClient.fetchLookupsForTierSync("default_tier")
);
}
+
+ @Test
+ public void test_getAllUsedSegments() throws JsonProcessingException
+ {
+ final List<DataSegment> segments = ImmutableList.of(SEGMENT1, SEGMENT2,
SEGMENT3);
+
+ serviceClient.expectAndRespond(
+ new RequestBuilder(
+ HttpMethod.GET,
+
"/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus&includeRealtimeSegments"
+ ),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(segments)
+ );
+
+ CloseableIterator<SegmentStatusInCluster> iterator =
FutureUtils.getUnchecked(
+ coordinatorClient.getAllUsedSegments(null, true, true),
+ true
+ );
+ List<SegmentStatusInCluster> actualSegments = new ArrayList<>();
+ while (iterator.hasNext()) {
+ actualSegments.add(iterator.next());
+ }
+ Assert.assertEquals(
+ segments,
+ actualSegments.stream()
+ .map(SegmentStatusInCluster::getDataSegment)
+ .collect(ImmutableList.toImmutableList())
+ );
+ }
+
+ @Test
+ public void test_getAllUsedSegments_noParams() throws JsonProcessingException
+ {
+ final List<DataSegment> segments = ImmutableList.of(SEGMENT1, SEGMENT2,
SEGMENT3);
+
+ serviceClient.expectAndRespond(
+ new RequestBuilder(
+ HttpMethod.GET,
+ "/druid/coordinator/v1/metadata/segments"
+ ),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(segments)
+ );
+
+ CloseableIterator<SegmentStatusInCluster> iterator =
FutureUtils.getUnchecked(
+ coordinatorClient.getAllUsedSegments(null, false, false),
+ true
+ );
+ List<SegmentStatusInCluster> actualSegments = new ArrayList<>();
+ while (iterator.hasNext()) {
+ actualSegments.add(iterator.next());
+ }
+ Assert.assertEquals(
+ segments,
+ actualSegments.stream()
+ .map(SegmentStatusInCluster::getDataSegment)
+ .collect(ImmutableList.toImmutableList())
+ );
+ }
+
+ @Test
+ public void test_getAllUsedSegments_excludeRealtimeSegments() throws
JsonProcessingException
+ {
+ final List<DataSegment> segments = ImmutableList.of(SEGMENT1, SEGMENT2,
SEGMENT3);
+
+ serviceClient.expectAndRespond(
+ new RequestBuilder(
+ HttpMethod.GET,
+ "/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus"
+ ),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(segments)
+ );
+
+ CloseableIterator<SegmentStatusInCluster> iterator =
FutureUtils.getUnchecked(
+ coordinatorClient.getAllUsedSegments(null, true, false),
+ true
+ );
+ List<SegmentStatusInCluster> actualSegments = new ArrayList<>();
+ while (iterator.hasNext()) {
+ actualSegments.add(iterator.next());
+ }
+ Assert.assertEquals(
+ segments,
+ actualSegments.stream()
+ .map(SegmentStatusInCluster::getDataSegment)
+ .collect(ImmutableList.toImmutableList())
+ );
+ }
+
+ @Test
+ public void test_getAllUsedSegments_filterByDataSource() throws Exception
+ {
+ serviceClient.expectAndRespond(
+ new RequestBuilder(
+ HttpMethod.GET,
+
"/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus&includeRealtimeSegments&datasources=abc"
+ ),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(ImmutableList.of(SEGMENT3))
+ );
+
+ CloseableIterator<SegmentStatusInCluster> iterator =
FutureUtils.getUnchecked(
+ coordinatorClient.getAllUsedSegments(Collections.singleton("abc"),
true, true),
+ true
+ );
+
+ List<SegmentStatusInCluster> actualSegments = new ArrayList<>();
+ while (iterator.hasNext()) {
+ actualSegments.add(iterator.next());
+ }
+ Assert.assertEquals(
+ ImmutableList.of(SEGMENT3),
+ actualSegments.stream()
+ .map(SegmentStatusInCluster::getDataSegment)
+ .collect(ImmutableList.toImmutableList())
+ );
+ }
+
+ @Test
+ public void test_getAllUsedSegments_filterByDataSourceOnly() throws Exception
+ {
+ serviceClient.expectAndRespond(
+ new RequestBuilder(
+ HttpMethod.GET,
+ "/druid/coordinator/v1/metadata/segments?datasources=abc"
+ ),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(ImmutableList.of(SEGMENT3))
+ );
+
+ CloseableIterator<SegmentStatusInCluster> iterator =
FutureUtils.getUnchecked(
+ coordinatorClient.getAllUsedSegments(Collections.singleton("abc"),
false, false),
+ true
+ );
+
+ List<SegmentStatusInCluster> actualSegments = new ArrayList<>();
+ while (iterator.hasNext()) {
+ actualSegments.add(iterator.next());
+ }
+ Assert.assertEquals(
+ ImmutableList.of(SEGMENT3),
+ actualSegments.stream()
+ .map(SegmentStatusInCluster::getDataSegment)
+ .collect(ImmutableList.toImmutableList())
+ );
+ }
+
+
+ @Test
+ public void test_getRulesForAllDatasources() throws Exception
+ {
+ final Map<String, List<Rule>> rules = ImmutableMap.of(
+ "xyz", List.of(
+ new IntervalLoadRule(
+ Intervals.of("2025-01-01/2025-02-01"),
+ ImmutableMap.of(DruidServer.DEFAULT_TIER,
DruidServer.DEFAULT_NUM_REPLICANTS),
+ null
+ ),
+ new IntervalLoadRule(
+ Intervals.of("2025-02-01/2025-03-01"),
+ ImmutableMap.of(DruidServer.DEFAULT_TIER,
DruidServer.DEFAULT_NUM_REPLICANTS),
+ null
+ )
+ )
+ );
+
+ serviceClient.expectAndRespond(
+ new RequestBuilder(HttpMethod.GET, "/druid/coordinator/v1/rules"),
+ HttpResponseStatus.OK,
+ ImmutableMap.of(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON),
+ jsonMapper.writeValueAsBytes(rules)
+ );
+
+ Assert.assertEquals(
+ rules,
+ coordinatorClient.getRulesForAllDatasources().get()
+ );
+ }
+
+ @Test
+ public void test_getRules_ForAllDatasources_HttpException_throwsError()
+ {
+ serviceClient.expectAndThrow(
+ new RequestBuilder(HttpMethod.GET, "/druid/coordinator/v1/rules"),
+ new HttpResponseException(
+ new StringFullResponseHolder(
+ new DefaultHttpResponse(HttpVersion.HTTP_1_1,
HttpResponseStatus.NOT_FOUND),
Review Comment:
gotcha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
