clintropolis commented on code in PR #18223:
URL: https://github.com/apache/druid/pull/18223#discussion_r2205547803
##########
processing/src/main/java/org/apache/druid/timeline/DataSegment.java:
##########
@@ -230,7 +246,7 @@ public DataSegment(
}
@Nullable
- private Map<String, Object> prepareLoadSpec(@Nullable Map<String, Object>
loadSpec)
+ private static Map<String, Object> prepareLoadSpec(@Nullable Map<String,
Object> loadSpec)
Review Comment:
nit: if you have to make any additional changes to this PR, maybe move these
static methods to be after the instance methods. this is just my personal
preference, so not a blocker or anything
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java:
##########
@@ -545,7 +545,7 @@ public void testGetTableMap()
final RelDataType rowType = segmentsTable.getRowType(new
JavaTypeFactoryImpl());
final List<RelDataTypeField> fields = rowType.getFieldList();
- Assert.assertEquals(19, fields.size());
+ Assert.assertEquals(20, fields.size());
Review Comment:
maybe we could add a test for a table with projections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
