kfaraz commented on code in PR #18255:
URL: https://github.com/apache/druid/pull/18255#discussion_r2209229691
##########
server/src/test/java/org/apache/druid/server/ClientQuerySegmentWalkerTest.java:
##########
@@ -987,10 +986,11 @@ public void testMetricsWithMaxSubqueryRowsEnabled()
ImmutableList.of(new Object[]{Intervals.ETERNITY.getStartMillis(), 3L})
);
- List<Event> events = emitter.getEvents();
+ List<StubServiceEmitter.ServiceMetricEventSnapshot> events =
+ emitter.getMetricEvents(ClientQuerySegmentWalker.ROWS_COUNT_METRIC);
- for (Event event : events) {
- EventMap map = event.toMap();
+ for (StubServiceEmitter.ServiceMetricEventSnapshot event : events) {
Review Comment:
Left a comment on the original PR
https://github.com/apache/druid/pull/17170#discussion_r2209227633
I have added a `ServiceMetricEvent.copy()` for now as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
