kfaraz commented on code in PR #18272: URL: https://github.com/apache/druid/pull/18272#discussion_r2213892724
########## processing/src/main/java/org/apache/druid/java/util/emitter/service/ServiceMetricEvent.java: ########## Review Comment: Yes, it keeps the patch small. Also, the `setDimensionIfNotNull` is essentially a short hand which does the null check for you, while the other throws exception on nulls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
