cecemei commented on code in PR #18250:
URL: https://github.com/apache/druid/pull/18250#discussion_r2216600303
##########
processing/src/test/java/org/apache/druid/segment/filter/RangeFilterTests.java:
##########
@@ -454,15 +454,19 @@ public void testNumericMatchExactlySingleValue()
);
assertFilterMatches(
new RangeFilter("d0", ColumnType.FLOAT, 120.0245f, 120.0245f, false,
false, null),
- ImmutableList.of()
+ ImmutableList.of("3")
Review Comment:
This test case feels a bit unclear to me. It appears to demonstrate the
behavior of comparing `double` and `float` values, but doesn't provide guidance
on the correct way to perform such comparisons. When comparing `float` and
`double`, it's best to use a tolerance range instead of exact value. For
example:
`new RangeFilter("d0", ColumnType.DOUBLE, 120.0243f, 120.0246f, false,
false, null)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
