GWphua commented on code in PR #18312:
URL: https://github.com/apache/druid/pull/18312#discussion_r2224772497
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -814,7 +814,13 @@ public void onFailure(Throwable t)
catch (Exception e) {
// (1) catch all exceptions while reading from kafka
caughtExceptionInner = e;
- log.error(e, "Encountered exception in run() before persisting.");
+ if (e instanceof InterruptedException || (e.getCause() != null
+ && e.getCause() instanceof
InterruptedException)) {
+ // InterruptedException stack trace is not that useful and will clog
up the logs.
Review Comment:
hi @kfaraz, Thanks for the suggestion!
Since InterruptedException does not have instantiator with a `Throwable`,
the root cause of an InterruptedException is the InterruptedException itself. I
have tidied the line to only be `Throwables.getRootCause(e) instanceof
InterruptedException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
