gianm opened a new pull request, #18322: URL: https://github.com/apache/druid/pull/18322
Fixes a regression from #18144. The refactoring in that patch lost some logic that ensured stage output channels were stored in read-only form. This is important, because the writable form includes a 1MB frame memory allocation buffer. It can add up to a lot of memory if retained across lots of channels. This patch simplifies things by unconditionally converting all stage outputs to read-only before they are retained, by replacing the channel in "stageOutputChannels.add(channel)" with "channel.readOnly()". It also simplifies various other bits of code that deal with intermediate output channels, by converting them to read-only in the constructors of ProcessorsAndChannels and ResultAndChannels, rather than at only some call sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
