kfaraz commented on code in PR #18321:
URL: https://github.com/apache/druid/pull/18321#discussion_r2230058041
##########
server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java:
##########
@@ -218,4 +217,22 @@ public OshiSysMonitor getOshiSysMonitor(
return new OshiSysMonitor(dimensions, oshiSysConfig);
}
}
+
+ /**
+ * Checks if a monitor needs to be loaded on this service based on its node
role.
+ */
+ private boolean shouldLoadMonitor(Class<?> monitorClass, Set<NodeRole>
nodeRoles)
+ {
+ final LoadScope loadScope = monitorClass.getAnnotation(LoadScope.class);
Review Comment:
Thanks! Updated to handle annotations on super-class and added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
