uds5501 commented on code in PR #18314:
URL: https://github.com/apache/druid/pull/18314#discussion_r2231138979
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -281,6 +286,7 @@ private void serverAddedSegment(final DruidServerMetadata
server, final DataSegm
timeline.add(segment.getInterval(), segment.getVersion(),
segment.getShardSpec().createChunk(selector));
selectors.put(segmentId, selector);
+ incrementSegmentCount(getMetricKey(segment));
Review Comment:
Hmm, two separate kind of events, let me add that as well.
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -281,6 +286,7 @@ private void serverAddedSegment(final DruidServerMetadata
server, final DataSegm
timeline.add(segment.getInterval(), segment.getVersion(),
segment.getShardSpec().createChunk(selector));
selectors.put(segmentId, selector);
+ incrementSegmentCount(getMetricKey(segment));
Review Comment:
Hmm, dedupe + two separate kind of events, let me add that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
