clintropolis commented on code in PR #18305: URL: https://github.com/apache/druid/pull/18305#discussion_r2240408963
########## processing/src/main/java/org/apache/druid/segment/shim/ShimColumnSelectorFactory.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.shim; + +import org.apache.druid.error.DruidException; +import org.apache.druid.query.dimension.DefaultDimensionSpec; +import org.apache.druid.query.dimension.DimensionSpec; +import org.apache.druid.segment.ColumnProcessors; +import org.apache.druid.segment.ColumnSelectorFactory; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.DimensionSelector; +import org.apache.druid.segment.NilColumnValueSelector; +import org.apache.druid.segment.column.ColumnCapabilities; +import org.apache.druid.segment.column.ValueType; +import org.apache.druid.segment.vector.MultiValueDimensionVectorSelector; +import org.apache.druid.segment.vector.SingleValueDimensionVectorSelector; +import org.apache.druid.segment.vector.VectorObjectSelector; + +import javax.annotation.Nullable; +import java.util.HashMap; +import java.util.Map; + +/** + * Implementation of {@link ColumnSelectorFactory} for {@link ShimCursor}. + */ +public class ShimColumnSelectorFactory implements ColumnSelectorFactory +{ + private final ShimCursor cursor; + private final Map<DimensionSpec, DimensionSelector> dimensionSelectors = new HashMap<>(); + private final Map<String, ColumnValueSelector<Object>> columnValueSelectors = new HashMap<>(); + + public ShimColumnSelectorFactory(ShimCursor cursor) + { + this.cursor = cursor; + } + + @Override + public DimensionSelector makeDimensionSelector(DimensionSpec dimensionSpec) + { + return dimensionSelectors.computeIfAbsent( + dimensionSpec, + spec -> { + if (spec.mustDecorate()) { + throw DruidException.defensive("Only non-decorated dimensions can be vectorized."); + } + final ColumnCapabilities capabilities = cursor.vectorColumnSelectorFactory + .getColumnCapabilities(dimensionSpec.getDimension()); + if (ColumnProcessors.useDictionaryEncodedSelector(capabilities)) { + if (capabilities.hasMultipleValues().isTrue()) { Review Comment: drive by comment: i can't remember if this can actually occur anymore for cursors after #17386, but otoh it doesn't hurt to be safe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
