clintropolis commented on code in PR #18335:
URL: https://github.com/apache/druid/pull/18335#discussion_r2246308702
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -486,4 +480,74 @@ public void writeTo(
}
log.info("Column [%s] serialized successfully with [%d] nested columns.",
name, fields.size());
}
+
+ @Override
+ public void setDictionaryIdLookup(DictionaryIdLookup dictionaryIdLookup)
+ {
+ this.globalDictionaryIdLookup = dictionaryIdLookup;
+ this.writeDictionary = false;
+ this.dictionarySerialized = true;
+ }
+
+ public void setFieldsAndOpenWriters(NestedDataColumnSerializer serializer)
throws IOException
Review Comment:
split out method to open the field writers which is the bulk of both loops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
