kfaraz opened a new pull request, #18349:
URL: https://github.com/apache/druid/pull/18349
### Description
Embedded tests currently run into serialization when submitting a `Task` or
`CompactionSupervisorSpec` payload to the cluster using any `OverlordClient`.
This can happen because the `ObjectMapper` instance used by the
`OverlordClient` might not have the necessary
Jackson modules loaded.
The hack so far has been to ensure that the first server in an embedded
cluster is always an Overlord.
But this can quickly run into issues, e.g. when running a cluster with basic
auth enabled where a
Coordinator must be started before all other servers.
### Fix
- Add utility methods in `EmbeddedClusterApis` to `submitTask`, `runTask`,
`postSupervisor`
- Accept an `EmbeddedOverlord` in these methods so that the appropriate
`OverlordClient` can be used
- The request is still sent over the wire since an Overlord also uses a
regular HTTP-based `OverlordClient`,
even if it might end up calling itself.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
