GWphua opened a new pull request, #18351:
URL: https://github.com/apache/druid/pull/18351

   ### Description
   
   <!-- Describe the goal of this PR, what problem are you fixing. If there is 
a corresponding issue (referenced above), it's not necessary to repeat the 
description here, however, you may choose to keep one summary sentence. -->
   
   <!-- Describe your patch: what did you change in code? How did you fix the 
problem? -->
   
   <!-- If there are several relatively logically separate changes in this PR, 
create a mini-section for each of them. For example: -->
   
   Failures due to Kubernetes pod creation will print a stack trace. However, 
the error message is more informative than the stack trace, so I am trying to 
do away with the stack trace now.
   
   ```
   2025-06-02T06:53:02,910 ERROR [k8s-task-runner-0] 
org.apache.druid.k8s.overlord.KubernetesTaskRunner - Task 
[index_parallel_wikipedia_heckhoam_2025-06-02T06:53:02.588Z] execution caught 
an exception
   org.apache.druid.k8s.overlord.common.KubernetesResourceNotFoundException: 
Job[indexparallelwikipediaheckhoam-191cf565e92f7fa565fb63885bf4d3fd] failed to 
start up pods. Reason: [FailedCreate], Message: [Error creating: pods 
"indexparallelwikipediaheckhoam-191cf565e92f7fa565fb638--1-plg69" is forbidden: 
memory max limit to request ratio per Container is 1, but provided ratio is 
1.333333]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.lambda$getPeonPodWithRetries$11(KubernetesPeonClient.java:282)
 ~[?:?]
        at 
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:129) 
~[druid-processing-27.0.0-SNAPSHOT.jar:27.0.0-SNAPSHOT]
        at 
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:81) 
~[druid-processing-27.0.0-SNAPSHOT.jar:27.0.0-SNAPSHOT]
        at 
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:163) 
~[druid-processing-27.0.0-SNAPSHOT.jar:27.0.0-SNAPSHOT]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.getPeonPodWithRetries(KubernetesPeonClient.java:264)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.lambda$getPeonPodWithRetries$10(KubernetesPeonClient.java:257)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.DruidKubernetesClient.executeRequest(DruidKubernetesClient.java:47)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.getPeonPodWithRetries(KubernetesPeonClient.java:257)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.lambda$launchPeonJobAndWaitForStart$1(KubernetesPeonClient.java:82)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.DruidKubernetesClient.executeRequest(DruidKubernetesClient.java:47)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.common.KubernetesPeonClient.launchPeonJobAndWaitForStart(KubernetesPeonClient.java:77)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.KubernetesPeonLifecycle.run(KubernetesPeonLifecycle.java:134)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.KubernetesTaskRunner.doTask(KubernetesTaskRunner.java:193)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.KubernetesTaskRunner.runTask(KubernetesTaskRunner.java:164)
 ~[?:?]
        at 
org.apache.druid.k8s.overlord.KubernetesTaskRunner.lambda$run$0(KubernetesTaskRunner.java:149)
 ~[?:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) 
~[?:?]
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) 
~[?:?]
        at java.lang.Thread.run(Thread.java:840) ~[?:?]
   
   ```
   
   #### Release note
   Add less-verbose error logs when K8s jobs are unable to create task pods, 
causing task failure. 
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `KubernetesTaskRunner`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] a release note entry in the PR description.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to