gianm commented on PR #17452: URL: https://github.com/apache/druid/pull/17452#issuecomment-3146365381
@maytasm did you intend to merge this one? You're a committer so you can reopen and click merge if you like. > As stated in the issue, the ideal change would be to have SqlResource inherit, or simply pass on, all query handling to QueryResource, but that seemed a bit out of scope for this PR (but I can do this). As to this, IMO it's useful to have `SqlResource` and `QueryResource` not be the same thing. There are definitely differences between them in terms of response format, for one. Also, `SqlResource` supports multiple engines via `SqlEngine`, whereas `QueryResource` does not. I haven't tried merging them, but I suspect that merging them would lead to the code being more confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
