clintropolis commented on code in PR #18342:
URL: https://github.com/apache/druid/pull/18342#discussion_r2259718444
##########
processing/src/main/java/org/apache/druid/data/input/impl/AggregateProjectionSpec.java:
##########
@@ -146,6 +163,7 @@ public boolean equals(Object o)
}
AggregateProjectionSpec that = (AggregateProjectionSpec) o;
return Objects.equals(name, that.name)
+ && Objects.equals(filter, that.filter)
Review Comment:
this is sort of aspirational - I think it would be possible someday for
ordering to not be fixed to grouping if we ever open up the comparator used to
sort data when building segments. However, no such plans for the time column.
(however the other part you noticed about relation between grouping and
ordering sort of breaks this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
