uds5501 commented on code in PR #18341:
URL: https://github.com/apache/druid/pull/18341#discussion_r2262313778
##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -464,6 +455,38 @@ private void configureOverlordHelpers(Binder binder)
);
}
+ private void bindTaskLogStreamer(Binder binder)
+ {
+ String logsType = properties.getProperty("druid.indexer.logs.type");
+ if ("switching".equals(logsType)) {
+ bindSwitchingTaskLogs(binder);
Review Comment:
This has been removed now.
##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -464,6 +455,38 @@ private void configureOverlordHelpers(Binder binder)
);
}
+ private void bindTaskLogStreamer(Binder binder)
+ {
+ String logsType = properties.getProperty("druid.indexer.logs.type");
+ if ("switching".equals(logsType)) {
+ bindSwitchingTaskLogs(binder);
+ } else {
+ bindSwitchingTaskLogStreamer(binder);
+ }
+ }
+
+ private static void bindSwitchingTaskLogStreamer(Binder binder)
Review Comment:
nuked
##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -464,6 +455,38 @@ private void configureOverlordHelpers(Binder binder)
);
}
+ private void bindTaskLogStreamer(Binder binder)
+ {
+ String logsType = properties.getProperty("druid.indexer.logs.type");
+ if ("switching".equals(logsType)) {
+ bindSwitchingTaskLogs(binder);
+ } else {
+ bindSwitchingTaskLogStreamer(binder);
+ }
+ }
+
+ private static void bindSwitchingTaskLogStreamer(Binder binder)
+ {
+ binder.bind(TaskLogStreamer.class)
+ .to(SwitchingTaskLogStreamer.class)
+ .in(LazySingleton.class);
+ binder.bind(new TypeLiteral<List<TaskLogStreamer>>() {})
+ .toProvider(new ListProvider<TaskLogStreamer>().add(TaskLogs.class))
+ .in(LazySingleton.class);
+
+ binder.bind(TaskLogStreamer.class)
+ .annotatedWith(Names.named("taskstreamer"))
+ .to(TaskRunnerTaskLogStreamer.class)
+ .in(LazySingleton.class);
+ }
+
+ private static void bindSwitchingTaskLogs(Binder binder)
Review Comment:
nuked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
