amaechler opened a new pull request, #18401:
URL: https://github.com/apache/druid/pull/18401

   ### Description
   
   The inline and file-based protobuf decoders depended on an external library 
[protobuf-dynamic](https://github.com/os72/protobuf-dynamic), which doesn't 
appear to be actively maintained anymore. It particularly [doesn't handle 
maps](https://github.com/os72/protobuf-dynamic/issues/19) well.
   
   Instead of using a third-party lib, we can achieve the same functionality 
(building a Protobuf descriptor from a file or Base64-encoded string) using the 
standard protobuf library. This PR does so.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever it would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to