kfaraz commented on code in PR #18383:
URL: https://github.com/apache/druid/pull/18383#discussion_r2280714877
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/KafkaDataFormatsTest.java:
##########
@@ -104,20 +104,26 @@ public class KafkaDataFormatsTest extends
EmbeddedClusterTestBase
private final EmbeddedOverlord overlord = new EmbeddedOverlord();
private final EmbeddedHistorical historical = new EmbeddedHistorical();
private final EmbeddedCoordinator coordinator = new EmbeddedCoordinator();
- private KafkaResource kafkaServer;
- private KafkaSchemaRegistryResource schemaRegistry;
+ private final KafkaResource kafkaServer = new KafkaResource();
+ private final KafkaSchemaRegistryResource schemaRegistry = new
KafkaSchemaRegistryResource(kafkaServer);
+
+ @AfterEach
+ public void afterEach() throws Exception
+ {
+ // I had an issue with tasks piling up, even when I added the supervisor
stop at the end of each test.
+ // This is a workaround to ensure that the tasks are cleared before the
next test runs.
+ // This is not ideal, but it works for now. Why are tasks not hard stopped
when the supervisor is terminated?
Review Comment:
Thanks for noting this down, we can address this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
