capistrant commented on code in PR #18435: URL: https://github.com/apache/druid/pull/18435#discussion_r2301218512
########## druid-operator/LICENSE: ########## Review Comment: I assume this needs to be deleted and druid-operator now falls under the core druid LICENSE file, but I'm not up to snuff on the license specifics with project donation to an apache project ########## druid-operator/.github/stale.yml: ########## Review Comment: can we delete? Druid repo should have its own stale PR handler if I remember correctly ########## druid-operator/.github/workflows/docker-image.yml: ########## Review Comment: does this need to be moved into base druid github workflows area? ########## druid-operator/MAINTAINERS.md: ########## Review Comment: Also a candidate for removal I think ########## druid-operator/README.md: ########## @@ -0,0 +1,65 @@ +<h2 align="center"> + <picture> + <img alt="DataInfra Logo" src="https://raw.githubusercontent.com/datainfrahq/.github/main/images/druid-operator.png"width="200"; height="200"> + </picture> + <br> + Kubernetes Operator For Apache Druid +</h2> + +<div align="center"> + +  [](https://github.com/datainfrahq/druid-operator/releases) [](https://kubernetes.slack.com/archives/C04F4M6HT2L) + +</div> + +- Druid Operator provisions and manages [Apache Druid](https://druid.apache.org/) cluster on kubernetes. +- Druid Operator is designed to provision and manage [Apache Druid](https://druid.apache.org/) in distributed mode only. +- It is built in Golang using [kubebuilder](https://github.com/kubernetes-sigs/kubebuilder). +- Refer to [Documentation](./docs/README.md) for getting started. +- Feel free to join Kubernetes slack and join [druid-operator](https://kubernetes.slack.com/archives/C04F4M6HT2L) + +### Newsletter - Monthly updates on running druid on kubernetes. +- [Apache Druid on Kubernetes](https://druidonk8s.substack.com/) + +### Talks and Blogs on Druid Operator + +- [Druid Summit 2023](https://druidsummit.org/agenda?agendaPath=session/1256850) +- [Dok Community](https://www.youtube.com/live/X4A3lWJRGHk?feature=share) +- [Druid Summit](https://youtu.be/UqPrttXRBDg) +- [Druid Operator Blog](https://www.cloudnatively.com/apache-druid-on-kubernetes/) +- [Druid On K8s Without ZK](https://youtu.be/TRYOvkz5Wuw) +- [Building Apache Druid on Kubernetes: How Dailymotion Serves Partner Data](https://youtu.be/FYFq-tGJOQk) + +### Supported CR's + +- The operator supports CR's of type ```Druid``` and ```DruidIngestion```. +- ```Druid``` and ```DruidIngestion``` CR belongs to api Group ```druid.apache.org``` and version ```v1alpha1``` + +### Druid Operator Architecture + + + +### Notifications + +- The project moved to <b>Kubebuilder v3</b> which requires a [manual change](docs/kubebuilder_v3_migration.md) in the operator. +- Users are encourage to use operator version 0.0.9+. +- The operator has moved from HPA apiVersion autoscaling/v2beta1 to autoscaling/v2 API users will need to update there HPA Specs according v2 api in order to work with the latest druid-operator release. +- druid-operator has moved Ingress apiVersion networking/v1beta1 to networking/v1. Users will need to update there Ingress Spec in the druid CR according networking/v1 syntax. In case users are using schema validated CRD, the CRD will also be needed to be updated. +- The v1.0.0 release for druid-operator is compatible with k8s version 1.25. HPA API is kept to version v2beta2. +- Release v1.2.2 had a bug for namespace scoped operator deployments, this is fixed in 1.2.3. + +### Kubernetes version compatibility + +| druid-operator | 0.0.9 | v1.0.0 | v1.1.0 | v1.2.2 | v1.2.3 | v1.2.4 | v1.2.5 | v1.3.0 | +| :------------- | :-------------: | :-----: | :---: | :---: | :---: | :---: | :---: | :---: | +| kubernetes <= 1.20 | :x:| :x: | :x: | :x: | :x: | :x: | :x: | :x: | +| kubernetes == 1.21 | :white_check_mark:| :x: | :x: | :x: | :x: | :x: | :x: | :x: | +| kubernetes >= 1.22 and <= 1.25 | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | +| kubernetes > 1.25 and <= 1.33.1 | :x: | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | + +### Contributors + +<a href="https://github.com/datainfrahq/druid-operator/graphs/contributors";><img src="https://contrib.rocks/image?repo=datainfrahq/druid-operator"/></a> Review Comment: this won't work anymore ########## druid-operator/README.md: ########## @@ -0,0 +1,65 @@ +<h2 align="center"> + <picture> + <img alt="DataInfra Logo" src="https://raw.githubusercontent.com/datainfrahq/.github/main/images/druid-operator.png"width="200"; height="200"> + </picture> + <br> + Kubernetes Operator For Apache Druid +</h2> + +<div align="center"> + +  [](https://github.com/datainfrahq/druid-operator/releases) [](https://kubernetes.slack.com/archives/C04F4M6HT2L) + +</div> + +- Druid Operator provisions and manages [Apache Druid](https://druid.apache.org/) cluster on kubernetes. +- Druid Operator is designed to provision and manage [Apache Druid](https://druid.apache.org/) in distributed mode only. +- It is built in Golang using [kubebuilder](https://github.com/kubernetes-sigs/kubebuilder). +- Refer to [Documentation](./docs/README.md) for getting started. +- Feel free to join Kubernetes slack and join [druid-operator](https://kubernetes.slack.com/archives/C04F4M6HT2L) Review Comment: I propose that we fold any druid-operator slack space into the apache druid slack space with a druid-operator slack room perhaps? ########## druid-operator/apis/druid/v1alpha1/druidingestion_types.go: ########## @@ -0,0 +1,102 @@ +/* Review Comment: I'll only comment once per file ext type :) -- all .go source files need the proper apache copy header Pulled from our java source files: ```JAVA /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ ``` ########## druid-operator/hack/api-docs/template/members.tpl: ########## Review Comment: I'm unfamiliar with `.tpl` but I do figure we will need apache copy headers in these too 🤔 ########## druid-operator/e2e/Dockerfile-testpod: ########## @@ -0,0 +1,7 @@ +FROM alpine:3.17.2 Review Comment: same license requirements for the Dockerfiles in the repo pulled from existing Dockerfile in repo ```Dockerfile # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. #------------------------------------------------------------------------- ``` ########## druid-operator/e2e/kind.sh: ########## Review Comment: same License stuff applies for `.sh` files From Druid repo existing script. comment came after shebang line + linebreak ``` # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional information regarding copyright ownership. # The ASF licenses this file to You under the Apache License, Version 2.0 # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. #------------------------------------------------------------------------- ``` ########## druid-operator/config/crd/bases/druid.apache.org_druidingestions.yaml: ########## Review Comment: I believe all the project YAML files will need the apache copy header. Example pulled from other druid Yaml file: ```YAML # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional information regarding copyright ownership. # The ASF licenses this file to You under the Apache License, Version 2.0 # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. #------------------------------------------------------------------------- ``` ########## druid-operator/README.md: ########## @@ -0,0 +1,65 @@ +<h2 align="center"> + <picture> + <img alt="DataInfra Logo" src="https://raw.githubusercontent.com/datainfrahq/.github/main/images/druid-operator.png"width="200"; height="200"> + </picture> + <br> + Kubernetes Operator For Apache Druid +</h2> + +<div align="center"> + +  [](https://github.com/datainfrahq/druid-operator/releases) [](https://kubernetes.slack.com/archives/C04F4M6HT2L) + +</div> + +- Druid Operator provisions and manages [Apache Druid](https://druid.apache.org/) cluster on kubernetes. +- Druid Operator is designed to provision and manage [Apache Druid](https://druid.apache.org/) in distributed mode only. +- It is built in Golang using [kubebuilder](https://github.com/kubernetes-sigs/kubebuilder). +- Refer to [Documentation](./docs/README.md) for getting started. +- Feel free to join Kubernetes slack and join [druid-operator](https://kubernetes.slack.com/archives/C04F4M6HT2L) + +### Newsletter - Monthly updates on running druid on kubernetes. +- [Apache Druid on Kubernetes](https://druidonk8s.substack.com/) + +### Talks and Blogs on Druid Operator + +- [Druid Summit 2023](https://druidsummit.org/agenda?agendaPath=session/1256850) +- [Dok Community](https://www.youtube.com/live/X4A3lWJRGHk?feature=share) +- [Druid Summit](https://youtu.be/UqPrttXRBDg) +- [Druid Operator Blog](https://www.cloudnatively.com/apache-druid-on-kubernetes/) +- [Druid On K8s Without ZK](https://youtu.be/TRYOvkz5Wuw) +- [Building Apache Druid on Kubernetes: How Dailymotion Serves Partner Data](https://youtu.be/FYFq-tGJOQk) + +### Supported CR's + +- The operator supports CR's of type ```Druid``` and ```DruidIngestion```. +- ```Druid``` and ```DruidIngestion``` CR belongs to api Group ```druid.apache.org``` and version ```v1alpha1``` + +### Druid Operator Architecture + + + +### Notifications + +- The project moved to <b>Kubebuilder v3</b> which requires a [manual change](docs/kubebuilder_v3_migration.md) in the operator. +- Users are encourage to use operator version 0.0.9+. +- The operator has moved from HPA apiVersion autoscaling/v2beta1 to autoscaling/v2 API users will need to update there HPA Specs according v2 api in order to work with the latest druid-operator release. +- druid-operator has moved Ingress apiVersion networking/v1beta1 to networking/v1. Users will need to update there Ingress Spec in the druid CR according networking/v1 syntax. In case users are using schema validated CRD, the CRD will also be needed to be updated. +- The v1.0.0 release for druid-operator is compatible with k8s version 1.25. HPA API is kept to version v2beta2. +- Release v1.2.2 had a bug for namespace scoped operator deployments, this is fixed in 1.2.3. + +### Kubernetes version compatibility + +| druid-operator | 0.0.9 | v1.0.0 | v1.1.0 | v1.2.2 | v1.2.3 | v1.2.4 | v1.2.5 | v1.3.0 | +| :------------- | :-------------: | :-----: | :---: | :---: | :---: | :---: | :---: | :---: | +| kubernetes <= 1.20 | :x:| :x: | :x: | :x: | :x: | :x: | :x: | :x: | +| kubernetes == 1.21 | :white_check_mark:| :x: | :x: | :x: | :x: | :x: | :x: | :x: | +| kubernetes >= 1.22 and <= 1.25 | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | +| kubernetes > 1.25 and <= 1.33.1 | :x: | :x: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | + +### Contributors + +<a href="https://github.com/datainfrahq/druid-operator/graphs/contributors";><img src="https://contrib.rocks/image?repo=datainfrahq/druid-operator"/></a> + +### Note Review Comment: please remove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://raw.githubusercontent.com/datainfrahq/.github/main/images/druid-operator.png"width="200"](https://raw.githubusercontent.com/datainfrahq/.github/main/images/druid-operator.png"width="200"){kind=link}
