abhishekrb19 commented on code in PR #18427:
URL: https://github.com/apache/druid/pull/18427#discussion_r2301961356
##########
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java:
##########
@@ -259,6 +270,9 @@ public boolean equals(Object o)
if (!getKafkaProducerConfig().equals(that.getKafkaProducerConfig())) {
return false;
}
+ if (!getShutdownTimeout().equals(that.getShutdownTimeout())) {
Review Comment:
It won't cause an NPE because the default `Long.MAX_VALUE` value is assigned
to the member variable in the ctr, but yeah the nullable annotation needs to be
removed
##########
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java:
##########
@@ -80,6 +81,8 @@ public static EventType fromString(String name)
private final Map<String, String> kafkaProducerConfig;
@JsonProperty("producer.hiddenProperties")
private final DynamicConfigProvider<String> kafkaProducerSecrets;
+ @Nullable @JsonProperty("producer.shutdownTimeout")
Review Comment:
```suggestion
@JsonProperty("producer.shutdownTimeout")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
