jtuglu1 commented on code in PR #18463:
URL: https://github.com/apache/druid/pull/18463#discussion_r2314460995
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -567,6 +569,10 @@ private TaskLockPosse createOrFindLockPosse(LockRequest
request, Task task, bool
giant.lock();
try {
+ if (!activeTasks.contains(task.getId())) {
Review Comment:
Not currently necessary, but I put this in for good measure since there's a
few call sites here (and in the future) which may pop-up. It's an O(1) (albeit
a large constant with large # of tasks though) check already under lock so
shouldn't be too expensive. Let me know if you want me to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
