clintropolis commented on code in PR #18507:
URL: https://github.com/apache/druid/pull/18507#discussion_r2335136529
##########
processing/src/main/java/org/apache/druid/math/expr/vector/ExprEvalDoubleVector.java:
##########
@@ -69,4 +70,13 @@ public Object[] getObjectVector()
}
return objects;
}
+
+ @Override
+ public boolean elementAsBoolean(int index)
+ {
+ if (nulls != null && nulls[index]) {
+ return Evals.asBoolean(0.0);
Review Comment:
it is, and i suppose it is unlikely we will ever change the behavior of the
`Evals.asBoolean` calls, I was just being overly cautious to match logic in
`ExprEval` exactly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
