clintropolis commented on code in PR #18424:
URL: https://github.com/apache/druid/pull/18424#discussion_r2342077134
##########
integration-tests/script/docker_run_cluster.sh:
##########
@@ -14,6 +14,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# Determine if docker compose is available. If not, assume Docker supports
+# the compose subcommand
+set +e
+if which docker-compose > /dev/null
+then
+ DOCKER_COMPOSE='docker-compose'
+else
+ DOCKER_COMPOSE='docker compose'
Review Comment:
shouldn't we prefer `docker compose`? i think `docker-compose` is pretty old
now and hasn't been included in docker distribution for a while now
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerInitUtils.java:
##########
@@ -109,15 +109,6 @@ public static void addFilters(ServletContextHandler
handler, Set<? extends Servl
}
}
- public static Handler getJettyRequestLogHandler()
- {
- // Ref:
http://www.eclipse.org/jetty/documentation/9.2.6.v20141205/configuring-jetty-request-logs.html
- RequestLogHandler requestLogHandler = new RequestLogHandler();
- requestLogHandler.setRequestLog(new JettyRequestLog());
-
- return requestLogHandler;
- }
Review Comment:
it looks like this is replaced with `Server.setRequestLog` in jetty 12,
https://jetty.org/docs/jetty/12.1/programming-guide/migration/11-to-12.html#api-changes-handler-requestlog,
do we need to add that somewhere like the server initializers class or
something?
##########
docs/operations/java.md:
##########
@@ -43,26 +43,18 @@ Druid relies on the environment variables `JAVA_HOME` or
`DRUID_JAVA_HOME` to fi
## Garbage collection
In general, the project team recommends using the G1 collector with default
settings. This is the default collector in
-Java 11 and 17.
+Java 17.
Garbage collector selection and tuning is a form of sport in the Java
community. There may be situations where adjusting
garbage collection configuration improves or worsens performance. The project
team's guidance is that most people do
not need to stray away from G1 with default settings.
## Strong encapsulation
-Java 9 and beyond (including Java 11 and 17) include the capability for
+Java 9 and beyond (including Java 17) include the capability for
[strong
encapsulation](https://dev.java/learn/strong-encapsulation-\(of-jdk-internals\)/)
of internal JDK APIs. Druid
uses certain internal JDK APIs, which must be added to `--add-exports` and
`--add-opens` on the Java command line.
-On Java 11, if these parameters are not included, you will see warnings like
the following:
-
-```
-WARNING: An illegal reflective access operation has occurred
-WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations
-WARNING: All illegal access operations will be denied in a future release
-```
-
Review Comment:
I think you still see these if you don't add the stuff, are we just assuming
that people are used to it by now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
