cecemei commented on code in PR #18403:
URL: https://github.com/apache/druid/pull/18403#discussion_r2342622005
##########
processing/src/main/java/org/apache/druid/segment/projections/Projections.java:
##########
@@ -383,17 +388,30 @@ public static ProjectionMatchBuilder
matchQueryVirtualColumn(
// virtual column and underlying expression itself, but this will do for
now
final Granularity virtualGranularity =
Granularities.fromVirtualColumn(queryVirtualColumn);
if (virtualGranularity != null) {
- if
(virtualGranularity.isFinerThan(projection.getEffectiveGranularity())) {
- return null;
- }
// same granularity, replace virtual column directly by remapping it
to the physical column
if (projection.getEffectiveGranularity().equals(virtualGranularity)) {
return matchBuilder.remapColumn(queryVirtualColumn.getOutputName(),
ColumnHolder.TIME_COLUMN_NAME)
.addReferencedPhysicalColumn(ColumnHolder.TIME_COLUMN_NAME);
+ } else if (Granularities.ALL.equals(virtualGranularity)
+ ||
Granularities.NONE.equals(projection.getEffectiveGranularity())) {
+ // if virtual gran is ALL or projection gran is NONE, it's
guaranteed that projection gran can be mapped to virtual gran
+ return
matchBuilder.addReferencedPhysicalColumn(ColumnHolder.TIME_COLUMN_NAME);
+ } else if (virtualGranularity instanceof PeriodGranularity
+ && projection.getEffectiveGranularity() instanceof
PeriodGranularity) {
+ PeriodGranularity virtualGran = (PeriodGranularity)
virtualGranularity;
+ PeriodGranularity projectionGran = (PeriodGranularity)
projection.getEffectiveGranularity();
+ byte[] combinedKey = StringUtils.toUtf8(projectionGran + "->" +
virtualGran);
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
