clintropolis commented on code in PR #18503:
URL: https://github.com/apache/druid/pull/18503#discussion_r2350240718
##########
processing/src/main/java/org/apache/druid/math/expr/vector/FallbackVectorProcessor.java:
##########
@@ -368,7 +368,7 @@ public ExprEval eval(ObjectBinding bindings)
final boolean isNull = results.getNullVector() != null &&
results.getNullVector()[rowNum];
return ExprEval.ofDouble(isNull ? null :
results.getDoubleVector()[rowNum]);
} else {
- return ExprEval.ofType(type, results.getObjectVector()[rowNum]);
+ return ExprEval.bestEffortOf(results.getObjectVector()[rowNum]);
Review Comment:
what was the problem with using `ofType` that is solved by best effort +
cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
