kfaraz commented on code in PR #18536:
URL: https://github.com/apache/druid/pull/18536#discussion_r2351539526
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamSupervisorSpecTest.java:
##########
@@ -851,6 +852,71 @@ public int getActiveTaskGroupsCount()
autoScaler.stop();
}
+ @Test
+ public void testScalingSkippedWhenPublishingTasks_EmitsCorrectSkipReason()
throws InterruptedException
Review Comment:
Nit: name suggestion to separate the following: method/functionality under
test, state, expected behaviour
```suggestion
public void
test_dynamicAllocationNotice_skipsScalingAndEmitsReason_ifTasksArePublishing()
throws InterruptedException
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -480,14 +485,16 @@ public void handle()
dataSource,
list
);
+ if (desiredTaskCount > 0) {
+ emitter.emit(event.setDimension(
+ AUTOSCALER_SKIP_REASON_DIMENSION,
+ "pendingCompletionTaskGroups non-empty"
Review Comment:
```suggestion
"There are tasks pending completion"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
