gianm commented on code in PR #18232:
URL: https://github.com/apache/druid/pull/18232#discussion_r2354612739
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java:
##########
@@ -2651,6 +2651,7 @@ public void testArrayAggMultiValue()
);
}
+ @NotYetSupported(Modes.DD_RESULT_MISMATCH_FLOAT_DOUBLE)
Review Comment:
Currently expression evaluation promotes floats to doubles internally
because there isn't specialized float-specific logic. We probably won't add it,
since it would require lots of new Java code. It's possible this promotion is
contributing to what you're seeing, since `ARRAY_AGG` uses expressions
internally.
I don't think this promotion is "bad", btw, it's just something that we
should try to have consistency around. Maybe you're saying the same thing with
the "result mismatch" tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
