gianm commented on code in PR #18521:
URL: https://github.com/apache/druid/pull/18521#discussion_r2356690563
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionVirtualColumn.java:
##########
@@ -274,6 +267,10 @@ public ColumnIndexSupplier getIndexSupplier(
ColumnIndexSelector columnIndexSelector
)
{
+ if (isDirectAccess(columnIndexSelector)) {
+ return
columnIndexSelector.getIndexSupplier(expression.parsed.get().getBindingIfIdentifier());
+ }
+
Review Comment:
It was just to align with all the other methods, which have a similar check.
It looked odd to me that this one didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
