Copilot commented on code in PR #18539:
URL: https://github.com/apache/druid/pull/18539#discussion_r2357218664
##########
processing/src/main/java/org/apache/druid/segment/CursorBuildSpec.java:
##########
@@ -235,7 +235,7 @@ public boolean isCompatibleOrdering(List<OrderBy> ordering)
return false;
}
for (int i = 0; i < preferredOrdering.size(); i++) {
- if (!ordering.get(i).equals(preferredOrdering.get(i))) {
+ if
(!ordering.get(i).getColumnName().equals(preferredOrdering.get(i).getColumnName()))
{
Review Comment:
This change relaxes the ordering direction requirement for projection
matching. Consider adding a comment explaining why direction comparison was
removed and that only column names need to match for projection compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
