clintropolis commented on code in PR #18541:
URL: https://github.com/apache/druid/pull/18541#discussion_r2364510682
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -1619,6 +1627,11 @@ public boolean putToKeyBuffer(RowBasedKey key, int idx)
final Object obj = key.getKey()[idx];
int id = getReverseDictionary().getInt(obj);
if (id == DimensionDictionary.ABSENT_VALUE_ID) {
+ int size = estimatedKeySize(key.getKey());
+ if (currentEstimatedSize + size > maxDictionarySize) {
+ return false;
+ }
+ currentEstimatedSize += size;
Review Comment:
this comment is correct, it should be `estimateKeySize(obj)`, not the whole
grouping key array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
