FrankChen021 commented on code in PR #18591:
URL: https://github.com/apache/druid/pull/18591#discussion_r2401040516
##########
extensions-core/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/taskadapter/K8sTaskAdapterTest.java:
##########
@@ -138,12 +138,12 @@ public PodSpec getSpec()
}
};
- KubernetesTaskRunnerConfig config = KubernetesTaskRunnerConfig.builder()
- .withNamespace("test")
- .withOverlordNamespace("test_different")
- .withAnnotations(ImmutableMap.of("annotation_key", "annotation_value"))
- .withLabels(ImmutableMap.of("label_key", "label_value"))
- .build();
+ KubernetesTaskRunnerStaticConfig config =
KubernetesTaskRunnerStaticConfig.builder()
Review Comment:
I think we can still keep the builder method in the interface, so that there
will not be any changes in the test cases
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -109,17 +111,20 @@ public class KubernetesTaskRunner implements
TaskLogStreamer, TaskRunner
protected final TaskAdapter adapter;
private final KubernetesPeonClient client;
- private final KubernetesTaskRunnerConfig config;
+ private final KubernetesTaskRunnerEffectiveConfig config;
Review Comment:
I think we can still keep using the interface declaration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
