jtuglu1 commented on code in PR #18515:
URL: https://github.com/apache/druid/pull/18515#discussion_r2366760334
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -371,15 +378,28 @@ public void createSegmentTable(final String tableName)
StringUtils.format(
createStatementBuilder.toString(),
tableName, getPayloadType(), getQuoteString(), getCollation()
- ),
- StringUtils.format("CREATE INDEX idx_%1$s_used ON %1$s(used)",
tableName),
- StringUtils.format(
- "CREATE INDEX idx_%1$s_datasource_used_end_start ON
%1$s(dataSource, used, %2$send%2$s, start)",
- tableName,
- getQuoteString()
)
)
);
+
+ final Set<String> createdIndexSet = getIndexOnTable(tableName);
+ createIndex(
+ tableName,
+ "idx_%1$s_used",
+ ImmutableList.of("used"),
+ createdIndexSet
+ );
+ createIndex(
+ tableName,
+ "idx_%1$s_datasource_used_end_start",
+ ImmutableList.of(
+ "dataSource",
+ "used",
+ StringUtils.format("%send%S", getQuoteString(), getQuoteString()),
Review Comment:
> It could just quote all the methods by default.
This actually causes some trouble with how engines parse the quotes vs not
when creating indices on the tables. With Derby, if the column isn't created in
the table with the same quoting format the index creation fails(e.g. "used" vs
used in the CT). I've left this as-is for now as it's only a handful of columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
