kfaraz commented on PR #18621: URL: https://github.com/apache/druid/pull/18621#issuecomment-3417933382
> I wasn’t able to find a CI build that currently fails due to this issue, but the ordering of a HashSet (which is a @JsonProperty in this case) is not guaranteed. This can potentially lead to nondeterministic behavior in the future, since SeekableStreamSupervisor.generateSequenceName() computes a hash code based on the serialized JSON. @Shiyang-Zhao , I looked at this some more. I also tried to run the `KafkaSupervisorTest.testIsTaskCurrent()` until failure but it didn't flake out. Were you able to cause it to fail by adding some items to `dimensionExclusions`? If yes, could you please add the failing test in this PR? A concern with changing the `dimensionExclusions` to either a sorted set or even a list is that when the Overlord is upgraded, we could adversely affect currently running supervisors. We would cause a different sequence name to be generated for the same supervisor thus causing the same problems (i.e. segment allocation and determining if a task is current) that we are trying to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
