capistrant commented on code in PR #18636: URL: https://github.com/apache/druid/pull/18636#discussion_r2432916267
########## codestyle/druid-forbidden-apis.txt: ########## @@ -63,7 +79,6 @@ org.apache.datasketches.memory.Memory#wrap(byte[], int, int, java.nio.ByteOrder) org.apache.druid.testing.simulate.EmbeddedMiddleManager#<init>() @ Middle Managers should be used for local embedded tests only and not pushed as they are slower and launch tasks as child processes. Use EmbeddedIndexer instead. org.apache.hadoop.fs.FileSystem#isDirectory(org.apache.hadoop.fs.Path) @ Use fileSystem.getFileStatus(path)#isDirectory() instead. org.apache.hadoop.fs.FileSystem#isFile(org.apache.hadoop.fs.Path) @ Use fileSystem.getFileStatus(path)#isPath instead. -java.lang.Class#getCanonicalName() @ Class.getCanonicalName can return null for anonymous types, use Class.getName instead. Review Comment: ohhh. I just missed that hiding in the big block of green additions. don't worry about reverting it. Thanks for pointing it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
