suraj-goel commented on code in PR #18525: URL: https://github.com/apache/druid/pull/18525#discussion_r2448146529
########## docs/ingestion/kafka-ingestion.md: ########## @@ -125,6 +125,7 @@ For configuration properties shared across all streaming ingestion methods, refe |`consumerProperties`|String, Object|A map of properties to pass to the Kafka consumer. See [Consumer properties](#consumer-properties) for details.|Yes. At the minimum, you must set the `bootstrap.servers` property to establish the initial connection to the Kafka cluster.|| |`pollTimeout`|Long|The length of time to wait for the Kafka consumer to poll records, in milliseconds.|No|100| |`useEarliestOffset`|Boolean|If a supervisor is managing a datasource for the first time, it obtains a set of starting offsets from Kafka. This flag determines whether the supervisor retrieves the earliest or latest offsets in Kafka. Under normal circumstances, subsequent tasks start from where the previous segments ended so this flag is only used on the first run.|No|`false`| +|`headerBasedInclusionConfig`|Object|Configuration for including Kafka records based on their headers before ingestion. See [Header-based inclusion filtering](#header-based-inclusion-filtering) for more details.|No|null| Review Comment: I think there's a confusion in naming as in the initial draft, I have used `headerBasedFilteringConfig`. This was a bit confusing as the name suggests that we are filtering based on the provided filters in the config. In reality, we are including the records based on the config and hence the name - `headerBasedInclusionConfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
