GWphua commented on code in PR #18687:
URL: https://github.com/apache/druid/pull/18687#discussion_r2459104019
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java:
##########
@@ -84,11 +97,31 @@ public List<StorageLocationConfig> getLocations()
return locations;
}
+ /**
+ * @deprecated Use {@link #getStartupCacheLoadStrategy()} instead.
+ * Removal of this method in the future will requires a change in {@link
#getStartupCacheLoadStrategy()}
+ * to default to {@link LoadAllEagerlyStrategy#STRATEGY_NAME} when {@link
#startupLoadStrategy} is null.
+ */
+ @Deprecated
public boolean isLazyLoadOnStart()
{
return lazyLoadOnStart;
}
+ public String getStartupCacheLoadStrategy()
+ {
+ return startupLoadStrategy == null
+ ? isLazyLoadOnStart()
Review Comment:
The current implementation ensures that a declared `startupLoadStrategy`
overwrites whatever `isLazyLoadOnStart` is set to, else `isLazyLoadOnStart` is
used for forward compatibility purposes. Personally, there is no need to
provide validation with this overwrite functionality -- though it is relatively
simple to implement one if you feel it's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
