kfaraz commented on code in PR #18690:
URL: https://github.com/apache/druid/pull/18690#discussion_r2459227980
##########
indexing-service/src/test/java/org/apache/druid/indexing/scheduledbatch/QuartzCronSchedulerConfigTest.java:
##########
@@ -111,8 +112,13 @@ public void testInvalidCronExpression()
DruidException.class,
() -> new QuartzCronSchedulerConfig("0 15 10 * *")
),
- DruidExceptionMatcher.invalidInput().expectMessageIs(
- "Quartz schedule[0 15 10 * *] is invalid: [Cron expression
contains 5 parts but we expect one of [6, 7]]"
+ Matchers.anyOf(
Review Comment:
Please add a one-line comment on the source of the flakiness.
##########
extensions-core/protobuf-extensions/src/test/java/org/apache/druid/data/input/protobuf/FileBasedProtobufBytesDecoderTest.java:
##########
@@ -132,7 +133,11 @@ public void testSingleDescriptorNoMessageType()
{
final var decoder = new
FileBasedProtobufBytesDecoder("proto_test_event.desc", null);
- assertEquals("google.protobuf.Timestamp",
decoder.getDescriptor().getFullName());
+ String actual = decoder.getDescriptor().getFullName();
Review Comment:
Please add a short comment on the source of the flakiness/difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]