capistrant commented on code in PR #18599: URL: https://github.com/apache/druid/pull/18599#discussion_r2462331112
########## extensions-core/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/taskadapter/DruidPeonClientIntegrationTest.java: ########## Review Comment: I haven't read through the test cases closely, but this seems to be candidate for Docker test (or deletion if the docker tests cover it already). I'll leave for a follow on PR as it feels out of scope. ########## extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DirectKubernetesPeonClient.java: ########## Review Comment: This is a copy of all the read code from the legacy KubernetesPeonClient. There may be optimizations to be made for this mode, but I consider that out of scope for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
