kfaraz commented on PR #18663:
URL: https://github.com/apache/druid/pull/18663#issuecomment-3449343309

   > The docs for the compactTask/availableSlot/count metric tripped me up a 
bit: “This is the max number of task slots minus any currently running 
compaction tasks,” rather than mentioning that it’s an estimated number of 
currently running compaction tasks.
   
   Fair point, @abhishekrb19 , it makes sense to update the docs.
   
   > also I think this can be determined using task/*/count
   
   Yes, that's true, we can get the running count for different task 
types/datasources using the `task/running/count` metric.
   
   > a consistent higher utilization of the busy slots metric (and a 
corresponding drop in available slots) would indicate the need to tune the 
compaction task slots
   
   I am not against emitting the busy slot count per se.
   Just didn't seem to add any new info since we are already emitting the max 
slot count and the available slot count.
   Please let me know if I am missing some use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to