aho135 commented on code in PR #18689: URL: https://github.com/apache/druid/pull/18689#discussion_r2466928947
########## extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/DimensionsAndCollector.java: ########## @@ -33,7 +37,7 @@ public class DimensionsAndCollector private final SimpleCollector collector; private final double conversionFactor; private final double[] histogramBuckets; - private final Stopwatch updateTimer; + private final ConcurrentHashMap<List<String>, Stopwatch> labelValuesToStopwatch; Review Comment: I haven't done any in depth memory profiling for this. I think it largely depends on how many unique label combinations there are. For something like queryId I'd imagine the memory usage would be higher under heavy query load. But for dimensions like taskId the memory usage should be much lower. I think it roughly gets offset anyway because we are clearing the label from the underlying SimpleCollector map now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
