GWphua opened a new pull request, #18700: URL: https://github.com/apache/druid/pull/18700
### Description <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. --> <!-- Describe your patch: what did you change in code? How did you fix the problem? --> <!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: --> The `peon.sh` file specifically specifies additional env vars that can be used: ``` # - DRUID_XMX -- set Java Xmx # - DRUID_XMS -- set Java Xms # - DRUID_MAXNEWSIZE -- set Java max new size # - DRUID_NEWSIZE -- set Java new size # - DRUID_MAXDIRECTMEMORYSIZE -- set Java max direct memory size ``` This used to be a lie, this PR aims to make this claim true. Note that this will not overwrite the existing `JAVA_OPTS` provided. This will make creating task pods with differing heap size / direct memory easier via Pod Templates. #### Release note <!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users. If your change doesn't have end user impact, you can skip this section. For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes). --> You can now pass `DRUID_XMX`, `DRUID_XMS`, `MAXDIRECTMEMORYSIZE`, `DRUID_MAXNEWSIZE`, `DRUID_NEWSIZE` to peon running in MM-less mode. <hr> ##### Key changed/added classes in this PR * `peon.sh` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
